Skip to content

Conversation

@duxiao1212
Copy link
Contributor

Summary:
Added spillBaseDir for PartitionAndSerializeReplayer

== NO RELEASE NOTE ==

Differential Revision: D86552256

Summary:
Added spillBaseDir for PartitionAndSerializeReplayer

```
== NO RELEASE NOTE ==
```

Differential Revision: D86552256
@duxiao1212 duxiao1212 requested review from a team as code owners November 7, 2025 22:22
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Nov 7, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 7, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR introduces a new spillBaseDir parameter to the PartitionAndSerializeReplayer, updating its constructor signature, propagating the argument through the implementation, and adjusting all call sites to include a placeholder value.

Class diagram for updated PartitionAndSerializeReplayer constructor

classDiagram
class PartitionAndSerializeReplayer {
  +PartitionAndSerializeReplayer(
    const std::string& taskId,
    const std::string& nodeId,
    const std::string& nodeName,
    const std::string& spillBaseDir,
    const std::string& driverIds,
    uint64_t queryCapacity,
    folly::Executor* executor
  )
}
PartitionAndSerializeReplayer --|> OperatorReplayerBase
Loading

File-Level Changes

Change Details Files
Add spillBaseDir parameter in PartitionAndSerializeReplayer
  • Extend constructor signature in header
  • Update implementation in .cpp to accept and forward spillBaseDir
  • Modify base class call to include new argument
PartitionAndSerializeReplayer.h
PartitionAndSerializeReplayer.cpp
Update all invocations with placeholder spillBaseDir
  • Insert empty string argument in TraceReplayerMain
  • Insert empty string argument in PartitionAndSerializeReplayerTest
TraceReplayerMain.cpp
PartitionAndSerializeReplayerTest.cpp
Remove redundant copyright comments
  • Delete commented-out license header in .cpp and .h files
PartitionAndSerializeReplayer.h
PartitionAndSerializeReplayer.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Expose spillBaseDir via a CLI flag in TraceReplayerMain instead of hardcoding an empty string
  • Add a test case that uses a non-empty spillBaseDir to verify the new parameter is correctly propagated
  • Restore or align the removed copyright/license headers with the project style guidelines
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Expose spillBaseDir via a CLI flag in TraceReplayerMain instead of hardcoding an empty string
- Add a test case that uses a non-empty spillBaseDir to verify the new parameter is correctly propagated
- Restore or align the removed copyright/license headers with the project style guidelines

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants